-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid decoding long runs in a single thread #16304
Draft
gerashegalov
wants to merge
27
commits into
rapidsai:branch-24.10
Choose a base branch
from
gerashegalov:gerashegalov/fixed_ukernel_rlestream_24.08_rebase_load_balancing
base: branch-24.10
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Avoid decoding long runs in a single thread #16304
gerashegalov
wants to merge
27
commits into
rapidsai:branch-24.10
from
gerashegalov:gerashegalov/fixed_ukernel_rlestream_24.08_rebase_load_balancing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dictionary Signed-off-by: Alessandro Bellina <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
Signed-off-by: Gera Shegalov <[email protected]>
…fixed_ukernel_rlestream_24.06_rebase_load_balancing
…fixed_ukernel_rlestream_24.08_rebase_load_balancing
…_rlestream_24.06_rebase_load_balancing' into gerashegalov/fixed_ukernel_rlestream_24.08_rebase_load_balancing
…fixed_ukernel_rlestream_24.08_rebase_load_balancing
…v/fixed_ukernel_rlestream_24.08_rebase_load_balancing
…v/fixed_ukernel_rlestream_24.08_rebase_load_balancing
Signed-off-by: Gera Shegalov <[email protected]>
…fixed_ukernel_rlestream_24.08_rebase_load_balancing
…fixed_ukernel_rlestream_24.08_rebase_load_balancing
Signed-off-by: Gera Shegalov <[email protected]>
gerashegalov
added
4 - Needs Review
Waiting for reviewer to review or respond
cuIO
cuIO issue
Performance
Performance related issue
labels
Jul 18, 2024
gerashegalov
changed the title
Gerashegalov/fixed ukernel rlestream 24.08 rebase load balancing
Avoid decoding long runs in a single thread
Jul 18, 2024
gerashegalov
added
Spark
Functionality that helps Spark RAPIDS
non-breaking
Non-breaking change
feature request
New feature or request
labels
Jul 18, 2024
…fixed_ukernel_rlestream_24.08_rebase_load_balancing
Signed-off-by: Gera Shegalov <[email protected]>
…fixed_ukernel_rlestream_24.08_rebase_load_balancing
…fixed_ukernel_rlestream_24.10_rebase_load_balancing
…fixed_ukernel_rlestream_24.10_rebase_load_balancing
…alov/fixed_ukernel_rlestream_24.10_rebase_load_balancing
…fixed_ukernel_rlestream_24.08_rebase_load_balancing
…fixed_ukernel_rlestream_24.08_rebase_load_balancing
don't forget to undo
Signed-off-by: Gera Shegalov <[email protected]>
Investigating a bug in this PR where batch_len goes negative on a 33M-row run:
|
Signed-off-by: Gera Shegalov <[email protected]>
Negative batch fixed with 09dd99e |
If the benchmark is scaled 100x by replicating the the 4 pages-x-250-million file the PR branch performance drops significantly Base wall clock for the query: 360 seconds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4 - Needs Review
Waiting for reviewer to review or respond
cuIO
cuIO issue
feature request
New feature or request
libcudf
Affects libcudf (C++/CUDA) code.
non-breaking
Non-breaking change
Performance
Performance related issue
Spark
Functionality that helps Spark RAPIDS
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split long runs among threads
Lead Co-authored-by: @abellina
Co-authored-by: @gerashegalov
Benchmarks
Generated files with a single integer column comprised of logically ~1 billion rows valued
1
.The benchmark Spark app iterates these files and executes
gpuDecodePageDataGeneric nsys the PR branch vs branch-24.10
ncu:
Checklist