Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON tree algorithms refactor I: CSR data structure for column tree #15979

Merged
merged 75 commits into from
Sep 25, 2024
Merged

JSON tree algorithms refactor I: CSR data structure for column tree #15979

merged 75 commits into from
Sep 25, 2024

Conversation

shrshi
Copy link
Contributor

@shrshi shrshi commented Jun 11, 2024 •
edited
Loading

Description

Part of #15903.

  1. Introduces the Compressed Sparse Row (CSR) format to store the adjacency information of the column tree.
  2. Analogous to reduce_to_column_tree, reduce_to_column_tree_csr reduces node tree representation to column tree stored in CSR format.

TODO:

  • Correctness test

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Jun 11, 2024
@shrshi shrshi added cuIO cuIO issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jun 11, 2024
@github-actions github-actions bot added the CMake CMake build issue label Jun 25, 2024
@shrshi shrshi marked this pull request as ready for review June 25, 2024 01:00
@shrshi shrshi requested a review from a team as a code owner June 25, 2024 01:00
@GregoryKimball GregoryKimball requested a review from ttnghia June 25, 2024 17:34
@ttnghia
Copy link
Contributor

ttnghia commented Jun 25, 2024

Question: Is this ready for review? Or still WIP?

@shrshi
Copy link
Contributor Author

shrshi commented Jun 25, 2024

Question: Is this ready for review? Or still WIP?

Sorry, forgot to update the title. It's ready for review.

@shrshi shrshi changed the title [WIP] JSON tree algorithms refactor I: CSR data structure for column tree JSON tree algorithms refactor I: CSR data structure for column tree Jun 25, 2024
@shrshi shrshi requested a review from a team as a code owner June 28, 2024 17:21
@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jun 28, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@shrshi
Copy link
Contributor Author

shrshi commented Jun 28, 2024

/ok to test

@shrshi shrshi mentioned this pull request Jul 6, 2024
Draft
8 tasks
vuule
vuule reviewed Sep 23, 2024
View reviewed changes
cpp/src/io/json/nested_json.hpp Outdated Show resolved Hide resolved
cpp/src/io/json/column_tree_construction.cu Outdated Show resolved Hide resolved
cpp/src/io/json/nested_json.hpp Outdated Show resolved Hide resolved
cpp/tests/io/json/json_tree_csr.cu Outdated Show resolved Hide resolved
@shrshi
Copy link
Contributor Author

shrshi commented Sep 23, 2024

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Sep 24, 2024

/ok to test

@shrshi
Copy link
Contributor Author

shrshi commented Sep 24, 2024

/ok to test

@ttnghia
Copy link
Contributor

ttnghia commented Sep 24, 2024

/ok to test

@galipremsagar
Copy link
Contributor

/okay to test

karthikeyann
karthikeyann reviewed Sep 25, 2024
View reviewed changes
cpp/tests/io/json/json_tree_csr.cu Outdated Show resolved Hide resolved
cpp/tests/io/json/json_tree_csr.cu Outdated Show resolved Hide resolved
cpp/tests/io/json/json_tree_csr.cu Outdated Show resolved Hide resolved
cpp/tests/io/json/json_tree_csr.cu Outdated Show resolved Hide resolved
karthikeyann
karthikeyann reviewed Sep 25, 2024
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
only minor cleanup.

cpp/src/io/json/column_tree_construction.cu Outdated Show resolved Hide resolved
@shrshi
Copy link
Contributor Author

shrshi commented Sep 25, 2024

/ok to test

@shrshi shrshi requested a review from karthikeyann September 25, 2024 02:45
karthikeyann
karthikeyann approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍
Looks good for merge.

@karthikeyann
Copy link
Contributor

/ok to test

KyleFromNVIDIA
KyleFromNVIDIA approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved trivial CMake changes

@shrshi shrshi added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 25, 2024
@shrshi
Copy link
Contributor Author

shrshi commented Sep 25, 2024

/merge

@rapids-bot rapids-bot bot merged commit 987fea3 into rapidsai:branch-24.10 Sep 25, 2024
102 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleFromNVIDIA KyleFromNVIDIA KyleFromNVIDIA approved these changes

@vuule vuule vuule approved these changes

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@revans2 revans2 revans2 approved these changes

@zpuller zpuller Awaiting requested review from zpuller zpuller is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@davidwendt davidwendt Awaiting requested review from davidwendt davidwendt is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@bdice bdice Awaiting requested review from bdice bdice was automatically assigned from rapidsai/packaging-codeowners

@vyasr vyasr Awaiting requested review from vyasr vyasr was automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@shrshi shrshi

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge CMake CMake build issue cuIO cuIO issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
cuDF Python
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@shrshi @ttnghia @GregoryKimball @vuule @galipremsagar @karthikeyann @revans2 @davidwendt @KyleFromNVIDIA