Remove index name overrides in dask-cudf pyarrow table dispatch #15514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesbluca
added
bug
charlesbluca
added
Python
|
/merge |
|
@charlesbluca looks like there are real failures here, so perhaps this change isn't safe after all? |
wence-
reviewed
Apr 17, 2024
wence-
reviewed
Apr 18, 2024
…a/remove-arrow-dispatch-overrides
….com:charlesbluca/cudf into charlesbluca/remove-arrow-dispatch-overrides
galipremsagar
approved these changes
Apr 19, 2024
…a/remove-arrow-dispatch-overrides
|
@wence- - any concerns with the recent Note: I basically set a breakpoint inside of |
rjzamora
reviewed
Apr 22, 2024
|
|
||
| out = super(DataFrame, data).to_arrow() | ||
| # import pdb; pdb.set_trace() |
There was a problem hiding this comment.
Oops- Forgot this PR was already marked with a /merge comment.
Forgot to remove this comment - Hopefully nothing else...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Looks like these overrides should be safe to remove now that #14159 is closed out.
This should unblock the GPU CI failures we're seeing on Dask with 24.06 in dask/dask#11045.
Checklist