Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up index methods #15496

Merged
merged 7 commits into from
Apr 22, 2024
Merged

Clean up index methods #15496

merged 7 commits into from
Apr 22, 2024

Conversation

mroeschke
Copy link
Contributor

@mroeschke mroeschke commented Apr 10, 2024 •
edited
Loading

Description

  • Removed _index_from_columns in favor of an inline call
  • Renamed _setdefault_name to _getdefault_name and to not modify kwargs

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added Python Affects Python cuDF API. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Apr 10, 2024
@mroeschke mroeschke requested a review from a team as a code owner April 10, 2024 01:18
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 818b29d into rapidsai:branch-24.06 Apr 22, 2024
70 checks passed
@mroeschke mroeschke deleted the ref/index2 branch April 22, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galipremsagar galipremsagar galipremsagar approved these changes

@shwina shwina Awaiting requested review from shwina shwina is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mroeschke @galipremsagar @vyasr