Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CUDF_USE_BENCHMARK_STATIC option to build and statically link Benchmark #15274

Closed

Conversation

trxcllnt
Copy link
Contributor

Description

Add CUDF_USE_BENCHMARK_STATIC option to build and statically link Benchmark.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@trxcllnt trxcllnt requested a review from a team as a code owner March 11, 2024 18:56
@trxcllnt trxcllnt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 11, 2024
@github-actions github-actions bot added libcudf Affects libcudf (C++/CUDA) code. CMake CMake build issue labels Mar 11, 2024
Copy link
Contributor

@robertmaynard robertmaynard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tempted to say that we should always use static nvbench and gbench to remove any need for these libraries in our test env.

@bdice your thoughts?

@bdice
Copy link
Contributor

bdice commented Mar 11, 2024

I was just about to say the same thing. I was hunting for a previous discussion of this topic and couldn't find it. We've discussed always statically linking nvbench/gbench and I think it would be a positive change.

@robertmaynard
Copy link
Contributor

I was just about to say the same thing. I was hunting for a previous discussion of this topic and couldn't find it. We've discussed always statically linking nvbench/gbench and I think it would be a positive change.

It might have been on raft, as they are now only using static for benchmark libraries.

@bdice
Copy link
Contributor

bdice commented Mar 11, 2024

Here's the most recent conversation where this was discussed: rapidsai/raft#1874 (review)

@vyasr
Copy link
Contributor

vyasr commented Mar 14, 2024

I'd be in favor of statically linking gbench/nvbench. Could we also do the same for tests?

@vyasr
Copy link
Contributor

vyasr commented May 21, 2024

This was addressed in #15534. We now use static gtest, benchmark, and nvbench everywhere.

@vyasr vyasr closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants