Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up usage of __CUDA_ARCH__ and other macros. #15218

Merged
merged 3 commits into from
Mar 5, 2024
Merged

Clean up usage of __CUDA_ARCH__ and other macros. #15218

merged 3 commits into from
Mar 5, 2024

Conversation

bdice
Copy link
Contributor

@bdice bdice commented Mar 4, 2024

Description

Closes #15030.

This PR cleans up references to __CUDA_ARCH__ and other macros.

  • We can safely drop Pascal support now that the required minimum is Volta (__CUDA_ARCH__ of 700).
  • Removed a leftover reference to CUDA 10.
  • Removed an instance of #if 1 that was no longer needed.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@bdice bdice requested a review from a team as a code owner March 4, 2024 14:21
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Mar 4, 2024
@davidwendt
Copy link
Contributor

The row_conversion.cu code was moved from the Spark repo to here temporarily and is slated to be moved back #14853
I'm guessing if we don't support Pascal then they would follow but it may be good to check with them.

@bdice
Copy link
Contributor Author

bdice commented Mar 4, 2024

@ttnghia Can you confirm the plan to remove the row conversion code? Can we safely merge the changes in this PR?

@bdice bdice added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Mar 4, 2024
@ttnghia
Copy link
Contributor

ttnghia commented Mar 4, 2024

Yes we will move it back to spark-rapids-jni very soon. I can do it this week if I have time. @hyperbolic2346 please review the code change here.

ttnghia
ttnghia approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@ttnghia ttnghia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in row_conversion.cu LGTM, as well as the rest.

hyperbolic2346
hyperbolic2346 approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@hyperbolic2346 hyperbolic2346 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

row conversion changes look magnificent. I always love removing complexity.

@bdice
Copy link
Contributor Author

bdice commented Mar 5, 2024

/merge

@rapids-bot rapids-bot bot merged commit b60bf18 into rapidsai:branch-24.04 Mar 5, 2024
73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@miscco miscco miscco approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove obsolete restrictions of __CUDA_ARCH__ >= 700.
5 participants
@bdice @davidwendt @ttnghia @miscco @hyperbolic2346