Lossless float <--> decimal conversion #15042
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidwendt
reviewed
Feb 13, 2024
| @@ -26,6 +26,7 @@ | |||
| #include <algorithm> | |||
| #include <cassert> | |||
| #include <cmath> | |||
| #include <limits> | |||
There was a problem hiding this comment.
Do not include this. Use the <cuda/std/limits> which is already included here
https://github.com/rapidsai/cudf/pull/15042/files#diff-2256e0f59727ecd8f361383f2f94b054b3c03d08ef3717876059d306fd616ab2R23
Likewise, use cuda::std::numeric_limits instead of std::numeric_limits
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lossless floating <--> decimal conversion for Issue 14169
Note: Only lossless if you use a small enough scaling factor to preserve the precision. If too small defaults back to the old algorithm.
Also small cleanup in rounding code
Checklist