Add ci check for external kernels #14768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertmaynard
added
feature request
This was referenced Jan 17, 2024
github-actions
bot
added
libcudf
robertmaynard
force-pushed
the
fea/add_ci_check_for_external_kernels
branch
from
da0203d to
05d48fa
Compare
robertmaynard
force-pushed
the
fea/add_ci_check_for_external_kernels
branch
from
05d48fa to
7c291f7
Compare
bdice
approved these changes
Jan 18, 2024
There was a problem hiding this comment.
Very nice. Sample error from CI:
Extracting symbols from /tmp/tmp.wVfIR9NVfn/lib/libcudf.so
Extracting symbols from /tmp/tmp.wVfIR9NVfn/lib/libcudf_identify_stream_usage_mode_testing.so
Extracting symbols from /tmp/tmp.wVfIR9NVfn/lib/libcudf_identify_stream_usage_mode_cudf.so
Extracting symbols from /tmp/tmp.wVfIR9NVfn/lib/libcudftest_default_stream.so
Extracting symbols from /tmp/tmp.wVfIR9NVfn/lib/libcudf_kafka.so
{
"_ZN4cudf2io3fst6detail26initialization_pass_kernelIN3cub33CUB_200200_700_750_800_860_900_NS13ScanTileStateIjLb1EEEEEvT_j": {
"/tmp/tmp.wVfIR9NVfn/lib/libcudf.so": [
"SASS",
"SASS",
"SASS",
"SASS",
"SASS"
],
"symbol": "void cudf::io::fst::detail::initialization_pass_kernel<cub::CUB_200200_700_750_800_860_900_NS::ScanTileState<unsigned int, true> >(cub::CUB_200200_700_750_800_860_900_NS::ScanTileState<unsigned int, true>, unsigned int)"
}
}
Error: Process completed with exit code 1.
42c1266 to
5af4390
Compare
vyasr
approved these changes
Jan 22, 2024
|
/merge |
raydouglass
approved these changes
Jan 23, 2024
3 tasks
rapids-bot bot
pushed a commit
that referenced
this pull request
Jan 24, 2024
Fixes some merge issues with outdated versions from #14768. I also made a minor tweak to `update-version.sh` that double-quotes some outputs to make pre-commit happier. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: #14854
PointKernel
pushed a commit
to PointKernel/cudf
that referenced
this pull request
Jan 25, 2024
Fixes some merge issues with outdated versions from rapidsai#14768. I also made a minor tweak to `update-version.sh` that double-quotes some outputs to make pre-commit happier. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Jake Awe (https://github.com/AyodeAwe) URL: rapidsai#14854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds CI checks so that libcudf doesn't reintroduce weak/external CUDA kernels.
Checklist