Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose streams in all public sorting APIs #14146

Merged
merged 7 commits into from
Sep 22, 2023
Merged

Expose streams in all public sorting APIs #14146

merged 7 commits into from
Sep 22, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Sep 21, 2023

Description

Contributes to #925

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@vyasr vyasr added feature request New feature or request 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Sep 21, 2023
@vyasr vyasr added this to the Enable streams milestone Sep 21, 2023
@vyasr vyasr self-assigned this Sep 21, 2023
@vyasr vyasr requested a review from a team as a code owner September 21, 2023 00:24
@vyasr vyasr requested review from bdice and davidwendt September 21, 2023 00:24
@github-actions github-actions bot added the CMake CMake build issue label Sep 21, 2023
@vyasr vyasr force-pushed the feat/streams_sorting branch from 689ea33 to 341a553 Compare September 21, 2023 00:25
bdice
bdice approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments need to be reflowed, but otherwise LGTM.

cpp/include/cudf/sorting.hpp Outdated Show resolved Hide resolved
@vyasr vyasr requested a review from davidwendt September 22, 2023 17:07
@vyasr
Copy link
Contributor Author

vyasr commented Sep 22, 2023

/merge

@rapids-bot rapids-bot bot merged commit 517d123 into rapidsai:branch-23.10 Sep 22, 2023
54 checks passed
@vyasr vyasr deleted the feat/streams_sorting branch September 22, 2023 20:16
@vyasr vyasr mentioned this pull request Sep 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidwendt davidwendt davidwendt approved these changes

@bdice bdice bdice approved these changes

Assignees

@vyasr vyasr

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
Enable streams
Development

Successfully merging this pull request may close these issues.
3 participants
@vyasr @bdice @davidwendt