Some additional kernel thread index refactoring. #14107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdice
commented
Sep 13, 2023
ttnghia
reviewed
Dec 7, 2023
| assert(start_idx < num_states); | ||
|
|
||
| curandState localState = state[start_idx]; | ||
|
|
||
| for (size_type idx = start_idx; idx < build_tbl_size; idx += stride) { | ||
| for (thread_index_type tidx = start_idx; tidx < build_tbl_size; tidx += stride) { |
There was a problem hiding this comment.
Should we add a range-based for loop to replace this pattern?
for(auto const tidx: grid_1d::thread_indices()) {...}
So we won't need to have stride like this.
There was a problem hiding this comment.
For now I'm going to leave that out of scope for this PR. I want to tighten the scope here and merge this since it's fairly old. Please feel free to comment on #10368 -- the topic of a range-based loop has already come up there.
bdice
added
improvement
…ad-index-refactors
davidwendt
approved these changes
May 6, 2024
|
I pushed a couple small fixes for benchmark builds (I hadn't run that locally yet). This should be ready to merge after CI passes. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors a few kernels to use
thread_index_typeand associated utilities. I started this before realizing how much scope was still left in issue #10368 ("Part 2 - Take another pass over more challenging kernels"), and then I stopped working on this due to time constraints. For the moment, I hope this PR makes a small dent in the number of remaining kernels to convert to usingthread_index_type.Checklist