Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for __round__ in Series and DataFrame #14099

Merged
merged 4 commits into from
Sep 13, 2023
Merged

Add support for __round__ in Series and DataFrame #14099

merged 4 commits into from
Sep 13, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes: #14083

This PR fixes builtin function round call on DataFrame & Series to work by implementing __round__ method.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. non-breaking Non-breaking change labels Sep 13, 2023
@galipremsagar galipremsagar self-assigned this Sep 13, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner September 13, 2023 00:50
@bdice
Copy link
Contributor

bdice commented Sep 13, 2023

@galipremsagar Might double check against the other operators listed in #10177, too.

@galipremsagar
Copy link
Contributor Author

galipremsagar commented Sep 13, 2023 •
edited
Loading

@galipremsagar Might double check against the other operators listed in #10177, too.

Nice ! Is it okay if I add __divmod__ & __rdivmod__ in a follow-up PR?

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team labels Sep 13, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 99c7711 into rapidsai:branch-23.10 Sep 13, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@vyasr vyasr Awaiting requested review from vyasr vyasr is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller brandon-b-miller is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Define DataFrame.__round__ for compat with round built-in function
2 participants
@galipremsagar @bdice