Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate ignore_index type in drop_duplicates #14098

Merged

Conversation

mroeschke
Copy link
Contributor

Description

Currently allows odd behavior like

In [1]: import cudf

In [4]: df = cudf.DataFrame({"a": [1, 2, 1, 3]})

In [6]: df.drop_duplicates(ignore_index="True")
Out[6]: 
   a
0  1
1  2
2  3

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working Python Affects Python cuDF API. non-breaking Non-breaking change labels Sep 13, 2023
@mroeschke mroeschke requested a review from a team as a code owner September 13, 2023 00:50
@galipremsagar
Copy link
Contributor

/merge

@galipremsagar galipremsagar added the 5 - Ready to Merge Testing and reviews complete, ready to merge label Sep 13, 2023
@rapids-bot rapids-bot bot merged commit c13b783 into rapidsai:branch-23.10 Sep 13, 2023
54 checks passed
@mroeschke mroeschke deleted the err/drop_duplicates/validate branch September 13, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants