Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DO NOT MERGE: testing Remove mr #14086

Closed
wants to merge 3 commits into from
Closed

DO NOT MERGE: testing Remove mr #14086

wants to merge 3 commits into from

Conversation

karthikeyann
Copy link
Contributor

@karthikeyann karthikeyann commented Sep 12, 2023 •
edited
Loading

Description

testing remove mr with compile options

@karthikeyann karthikeyann added tests Unit testing for project 5 - DO NOT MERGE Hold off on merging; see PR for details improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 12, 2023
@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Sep 12, 2023
@copy-pr-bot
Copy link

copy-pr-bot bot commented Sep 12, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the CMake CMake build issue label Sep 12, 2023
@karthikeyann
Copy link
Contributor Author

/ok to test

@karthikeyann karthikeyann added 2 - In Progress Currently a work in progress and removed 5 - DO NOT MERGE Hold off on merging; see PR for details labels Sep 12, 2023
@karthikeyann karthikeyann force-pushed the chore/fully_remove_test_mr branch from e2da4d3 to 292dc16 Compare September 12, 2023 12:02
@karthikeyann karthikeyann force-pushed the chore/fully_remove_test_mr branch from 292dc16 to 8c2e012 Compare September 12, 2023 12:07
@karthikeyann
Copy link
Contributor Author

/ok to test

@karthikeyann
Copy link
Contributor Author

karthikeyann commented Sep 12, 2023 •
edited
Loading

STRINGS_TEST (Failed) on all machines.
@robertmaynard

[ RUN      ] StringsConvertTest.FixedPointStringConversionOperator
/opt/conda/conda-bld/work/cpp/tests/strings/fixed_point_tests.cpp:328: Failure
Expected equality of these values:
  static_cast<std::string>(x)
    Which is: "-1.0000000000"
  "17014118346046923173168730371.5884105727"

[  FAILED  ] StringsConvertTest.FixedPointStringConversionOperator (0 ms)

@bdice
Copy link
Contributor

bdice commented Sep 13, 2023

FWIW, 17014118346046923173168730371.5884105727 is the value 2^127 - 1 shifted by 10 decimal places. Probably has to do with decimal128 representation somewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertmaynard robertmaynard Awaiting requested review from robertmaynard

@vyasr vyasr Awaiting requested review from vyasr

@bdice bdice Awaiting requested review from bdice

Assignees
No one assigned
Labels
2 - In Progress Currently a work in progress CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change tests Unit testing for project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karthikeyann @bdice @vyasr @robertmaynard