Remove header tests #14072
Merged
Remove header tests #14072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From some internal Slack discussions, it was determined that the `headers_test.sh` file is no longer necessary. This PR removes it and its associated checks.
ajschmidt8
added
improvement
raydouglass
approved these changes
Sep 8, 2023
|
/merge |
bdice
reviewed
Sep 8, 2023
This was referenced Apr 30, 2024
rapids-bot bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
May 1, 2024
This PR removes header existence tests from the librmm conda recipe to reduce friction when code is moved. Closes #1549. These changes are similar to rapidsai/cudf#14072. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Mark Harris (https://github.com/harrism) - Lawrence Mitchell (https://github.com/wence-) - Ray Douglass (https://github.com/raydouglass) URL: #1550
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From some internal Slack discussions, it was determined that the
headers_test.shfile is no longer necessary.This PR removes it and its associated checks.