Update pyarrow-related dispatch logic in dask_cudf #14069
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request rapidsai#5690 from ajschmidt8/phase2 [skip ci] Update master references for main branch
[RELEASE] Re-release v0.15 cudf [skip-ci]
[RELEASE] cudf v0.17
[RELEASE] cudf v0.18
[RELEASE] Release v0.18.1 cudf
[RELEASE] v0.18.2 `cudf` release [skip-ci]
[RELEASE] v0.19.1 cudf
[RELEASE] v0.19.2 cudf [skip-ci]
rjzamora
added
bug
|
/ok to test |
wence-
approved these changes
Sep 13, 2023
| "Ignoring the following arguments to " | ||
| f"`pyarrow_schema_dispatch`: {list(kwargs)}" | ||
| ) | ||
| return obj.to_arrow(preserve_index=preserve_index).schema |
There was a problem hiding this comment.
thought (non-blocking): If dask asks for the schema separately from the table it would be good to figure out a way to provide a pyarrow schema for a cudf dataframe without necessarily copying the full frame to host. Ideally producing this metadata should be O(1) rather than (as it is now) O(size-of-frame).
There was a problem hiding this comment.
Yeah, good call. The specific logic in _get_pyarrow_schema_cudf wasn't really part of this PR, but that's an excellent point. It definitely feels like we should be able to produce a schema without moving all the data!
There was a problem hiding this comment.
Using meta_nonempty(obj) seems to do the trick here.
|
/ok to test |
…/cudf into preserve-index-dispatch
|
/ok to test |
rjzamora
added
5 - Ready to Merge
|
/merge |
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates
dask_cudfdispatch logic to avoid breakage from dask/dask#10500.Also removes stale
try/exceptlogic.Checklist