Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose streams in public strings case APIs #14056

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Expose streams in public strings case APIs #14056

merged 5 commits into from
Sep 18, 2023

Conversation

davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Sep 7, 2023 •
edited
Loading

Description

Add stream parameter to public strings APIs:

  • cudf::strings::capitalize()
  • cudf::strings::title()
  • cudf::strings::is_title()
  • cudf::strings::to_lower()
  • cudf::strings::to_upper()
  • cudf::strings::swapcase()

Reference #13744

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. strings strings issues (C++ and Python) improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Sep 7, 2023
@davidwendt davidwendt requested a review from a team as a code owner September 7, 2023 17:29
@davidwendt davidwendt self-assigned this Sep 7, 2023
vyasr
vyasr requested changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@vyasr vyasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests please.

@github-actions github-actions bot added the CMake CMake build issue label Sep 13, 2023
@davidwendt davidwendt requested a review from vyasr September 13, 2023 20:01
@davidwendt
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit bdc1f3a into rapidsai:branch-23.10 Sep 18, 2023
59 checks passed
@davidwendt davidwendt deleted the stream-strings-case branch September 18, 2023 23:34
@GregoryKimball GregoryKimball mentioned this pull request Sep 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyasr vyasr vyasr approved these changes

@harrism harrism harrism approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann karthikeyann is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change strings strings issues (C++ and Python)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwendt @harrism @vyasr