Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Index.difference to match with pandas #14053

Merged
merged 8 commits into from
Sep 8, 2023

Conversation

galipremsagar
Copy link
Contributor

@galipremsagar galipremsagar commented Sep 7, 2023

Description

This PR fixes Index.difference in following ways:

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Sep 7, 2023
@galipremsagar galipremsagar self-assigned this Sep 7, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner September 7, 2023 05:29
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I think there's a missing corner-case in the reconstruct logic, and cupy appears to be a bit fast than conversion to a frame for the unique call

python/cudf/cudf/core/index.py Outdated Show resolved Hide resolved
python/cudf/cudf/core/index.py Outdated Show resolved Hide resolved
@mroeschke
Copy link
Contributor

Does this close #14013?

@galipremsagar
Copy link
Contributor Author

Does this close #14013?

Yup. Linked to the PR.

@galipremsagar galipremsagar requested a review from wence- September 8, 2023 00:16
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (Didn't know an index could have nulls!)

@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 8, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 01730c4 into rapidsai:branch-23.10 Sep 8, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
3 participants