Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix empty string column construction #14052

Merged
merged 4 commits into from
Sep 7, 2023
Merged

Fix empty string column construction #14052

merged 4 commits into from
Sep 7, 2023

Conversation

galipremsagar
Copy link
Contributor

Description

Fixes #14046

This PR fixes empty string column construction that arises due to a corner-case in the way pyarrow constructs arrays.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@galipremsagar galipremsagar added bug Something isn't working 3 - Ready for Review Ready for review by team Python Affects Python cuDF API. 4 - Needs cuDF (Python) Reviewer non-breaking Non-breaking change labels Sep 7, 2023
@galipremsagar galipremsagar requested a review from a team as a code owner September 7, 2023 05:29
@galipremsagar galipremsagar self-assigned this Sep 7, 2023
bdice
bdice approved these changes Sep 7, 2023
View reviewed changes
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request for simplified logic, otherwise LGTM.

python/cudf/cudf/core/column/column.py Outdated Show resolved Hide resolved
@galipremsagar galipremsagar added 5 - Ready to Merge Testing and reviews complete, ready to merge and removed 3 - Ready for Review Ready for review by team 4 - Needs cuDF (Python) Reviewer labels Sep 7, 2023
@galipremsagar
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit c9d8821 into rapidsai:branch-23.10 Sep 7, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdice bdice bdice approved these changes

@isVoid isVoid Awaiting requested review from isVoid isVoid is a code owner automatically assigned from rapidsai/cudf-python-codeowners

Assignees

@galipremsagar galipremsagar

Labels
5 - Ready to Merge Testing and reviews complete, ready to merge bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Calling cudf.from_pandas on empty index isn't preserving the dtype for string column
2 participants
@galipremsagar @bdice