Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise TypeError for any non-parseable argument in to_datetime #14044

Merged

Conversation

mroeschke
Copy link
Contributor

Description

Avoids the following incorrect behavior

In [7]: cudf.to_datetime([True])
Out[7]: GenericIndex([True], dtype='bool')

In [1]: import pandas

In [2]: pandas.to_datetime([True])
TypeError: <class 'bool'> is not convertible to datetime

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@mroeschke mroeschke added bug Something isn't working non-breaking Non-breaking change labels Sep 6, 2023
@mroeschke mroeschke requested a review from a team as a code owner September 6, 2023 20:54
@github-actions github-actions bot added the Python Affects Python cuDF API. label Sep 6, 2023
@mroeschke
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0190c29 into rapidsai:branch-23.10 Sep 7, 2023
55 checks passed
@mroeschke mroeschke deleted the bug/to_datetime/typerror branch September 7, 2023 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants