Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bytes_per_second to shift benchmark #13950

Merged
merged 11 commits into from
Oct 10, 2023
Merged

Add bytes_per_second to shift benchmark #13950

merged 11 commits into from
Oct 10, 2023

Conversation

Blonck
Copy link
Contributor

@Blonck Blonck commented Aug 24, 2023

Adds bytes_per_second to SHIFT_BENCH.

This patch relates to #13735.

Checklist

@Blonck Blonck requested a review from a team as a code owner August 24, 2023 14:47
@rapids-bot
Copy link

rapids-bot bot commented Aug 24, 2023

Pull requests from external contributors require approval from a rapidsai organization member with write permissions or greater before CI can begin.

@github-actions github-actions bot added the libcudf Affects libcudf (C++/CUDA) code. label Aug 24, 2023
@davidwendt davidwendt added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Aug 24, 2023
@davidwendt
Copy link
Contributor

/ok to test

1 similar comment
@davidwendt
Copy link
Contributor

/ok to test

@copy-pr-bot
Copy link

copy-pr-bot bot commented Aug 30, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@davidwendt
Copy link
Contributor

/ok to test

karthikeyann
karthikeyann approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@karthikeyann karthikeyann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@davidwendt
Copy link
Contributor

/ok to test

1 similar comment
@davidwendt
Copy link
Contributor

/ok to test

@Blonck
Copy link
Contributor Author

Blonck commented Sep 18, 2023

CI for conda-python-build / build (12.0.1, ubuntu22.04, amd64, 3.9) with a conda error. I assume that it's not related to this patch :). I would rebase the PR in a few days onto branch-23.10 and push it again.

@karthikeyann
Copy link
Contributor

/ok to test

@Blonck Blonck force-pushed the processed_bytes_shift_benchmark branch from 9339f74 to 6148cb2 Compare September 26, 2023 14:01
@Blonck Blonck requested review from a team as code owners September 26, 2023 14:01
@Blonck Blonck requested a review from vyasr September 26, 2023 14:01
@github-actions github-actions bot removed Python Affects Python cuDF API. CMake CMake build issue conda Java Affects Java cuDF API. labels Sep 27, 2023
@wence- wence- removed request for a team, vyasr and galipremsagar October 2, 2023 08:01
@wence-
Copy link
Contributor

wence- commented Oct 2, 2023

/ok to test

@harrism
Copy link
Member

harrism commented Oct 2, 2023

Remember to run pre-commit run before commiting to avoid clang-format errors. (Or format on save).

@harrism
Copy link
Member

harrism commented Oct 3, 2023

/ok to test

harrism
harrism requested changes Oct 3, 2023
View reviewed changes
Copy link
Member

@harrism harrism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, just trying to consolidate the use of types.

cpp/benchmarks/copying/shift.cu Outdated Show resolved Hide resolved
cpp/benchmarks/copying/shift.cu Outdated Show resolved Hide resolved
cpp/benchmarks/copying/shift.cu Outdated Show resolved Hide resolved
@Blonck
Copy link
Contributor Author

Blonck commented Oct 4, 2023 •
edited
Loading

Sorry, just trying to consolidate the use of types.

No, problem.

Just to mention it: With the latest change, technically, it is not longer the same benchmark as it does not longer depend on the width of int :) (I guess only on platforms which anyways are not supported.)

@harrism
Copy link
Member

harrism commented Oct 4, 2023

/ok to test

@harrism
Copy link
Member

harrism commented Oct 4, 2023

/merge

1 similar comment
@ttnghia
Copy link
Contributor

ttnghia commented Oct 10, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0ed7725 into rapidsai:branch-23.12 Oct 10, 2023
65 checks passed
@GregoryKimball GregoryKimball mentioned this pull request Nov 3, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttnghia ttnghia ttnghia approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@harrism harrism harrism approved these changes

@robertmaynard robertmaynard Awaiting requested review from robertmaynard robertmaynard is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

@divyegala divyegala Awaiting requested review from divyegala divyegala is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Blonck @davidwendt @karthikeyann @wence- @harrism @ttnghia