Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow explicit shuffle="p2p" within dask-cudf API #13893

Merged
merged 119 commits into from
Sep 25, 2023

Conversation

rjzamora
Copy link
Member

Description

This PR allows explicit shuffle="p2p" usage within the dask-cudf API now that dask/distributed#7743 is in.

raydouglass and others added 30 commits March 30, 2020 11:03
Merge pull request rapidsai#5690 from ajschmidt8/phase2
[skip ci] Update master references for main branch
[RELEASE] Re-release v0.15 cudf [skip-ci]
[RELEASE] v0.18.2 `cudf` release [skip-ci]
@rjzamora
Copy link
Member Author

rjzamora commented Sep 21, 2023

Just leaving a note that this is currently blocked by #14159 [EDIT: This PR now contains a work-around for #14159]

@rjzamora
Copy link
Member Author

/ok to test

@rjzamora
Copy link
Member Author

/ok to test

@rjzamora
Copy link
Member Author

/ok to test

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@rjzamora
Copy link
Member Author

/ok to test

@rjzamora
Copy link
Member Author

@wence- - I know you approved this PR a few days ago, but the scope has changed a bit. Let me know if you still think this is good to go.

Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small suggested simplification.

python/dask_cudf/dask_cudf/backends.py Outdated Show resolved Hide resolved
@wence-
Copy link
Contributor

wence- commented Sep 25, 2023

/ok to test

@rjzamora
Copy link
Member Author

/ok to test

@wence-
Copy link
Contributor

wence- commented Sep 25, 2023

Sorry, I broke the style check, shall I fix?

@rjzamora
Copy link
Member Author

/ok to test

@wence-
Copy link
Contributor

wence- commented Sep 25, 2023

/merge

@rapids-bot rapids-bot bot merged commit ddd2b0d into rapidsai:branch-23.10 Sep 25, 2023
54 checks passed
@rjzamora rjzamora deleted the unlock-p2p branch September 25, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team dask Dask issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python Affects Python cuDF API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants