Address reviews 1

rapidsai · Aug 27, 2024 · f7ac4bd · f7ac4bd
1 parent f2a9106
commit f7ac4bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cpp/benchmarks/common/cudf_tpch_datagen/random_column_generator.cu b/cpp/benchmarks/common/cudf_tpch_datagen/random_column_generator.cu
@@ -67,7 +67,7 @@ struct random_number_generator {
 
   __host__ __device__ T operator()(const int64_t idx) const
   {
-    if (cudf::is_integral<T>()) {
+    if constexpr (cudf::is_integral<T>()) {
       thrust::default_random_engine engine;
       thrust::uniform_int_distribution<T> dist(lower, upper);
       engine.discard(idx);

diff --git a/cpp/benchmarks/common/cudf_tpch_datagen/table_helpers.cpp b/cpp/benchmarks/common/cudf_tpch_datagen/table_helpers.cpp
@@ -296,7 +296,8 @@ std::unique_ptr<cudf::table> perform_left_join(cudf::table_view const& left_inpu
   auto const sum_agg = cudf::make_sum_aggregation<cudf::reduce_aggregation>();
   auto const l_num_rows_scalar =
     cudf::reduce(o_rep_freqs, *sum_agg, cudf::data_type{cudf::type_id::INT32}, stream, mr);
-  return reinterpret_cast<cudf::numeric_scalar<cudf::size_type>*>(l_num_rows_scalar.get())->value();
+  return reinterpret_cast<cudf::numeric_scalar<cudf::size_type>*>(l_num_rows_scalar.get())
+    ->value(stream);
 }
 
 /**