Discard null mask if there is no nulls

Signed-off-by: Nghia Truong <[email protected]>
rapidsai · Oct 10, 2024 · ee5b7fd · ee5b7fd
1 parent 7453ef4
commit ee5b7fd
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/cpp/src/strings/strings_column_factories.cu b/cpp/src/strings/strings_column_factories.cu
@@ -191,11 +191,14 @@ std::vector<std::unique_ptr<column>> make_strings_column_batch(
                                         strings_count,
                                         stream,
                                         mr);
-    output[idx]     = make_strings_column(strings_count,
-                                      std::move(offsets_cols[idx]),
-                                      chars_data.release(),
-                                      strings_count - valid_count,
-                                      std::move(null_masks[idx]));
+
+    auto const null_count = strings_count - valid_count;
+    output[idx] =
+      make_strings_column(strings_count,
+                          std::move(offsets_cols[idx]),
+                          chars_data.release(),
+                          null_count,
+                          null_count ? std::move(null_masks[idx]) : rmm::device_buffer{});
   }
 
   return output;