Skip to content

Commit

Permalink
Disable large string support for Java build (#16216)
Browse files Browse the repository at this point in the history
Disables libcudf large string support for the Java bindings build. The Java bindings need to be updated to handle large strings which is tracked by #16215.

Closes #16199.

Authors:
  - Jason Lowe (https://github.com/jlowe)

Approvers:
  - Nghia Truong (https://github.com/ttnghia)

URL: #16216
  • Loading branch information
jlowe authored Jul 8, 2024
1 parent e9cb7dd commit cc8c868
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 4 deletions.
10 changes: 7 additions & 3 deletions java/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,13 @@ CUDA 11.0:
## Build From Source

Build [libcudf](../cpp) first, and make sure the JDK is installed and available. Specify
the cmake option `-DCUDF_USE_ARROW_STATIC=ON -DCUDF_ENABLE_ARROW_S3=OFF` when building so
that Apache Arrow is linked statically to libcudf, as this will help create a jar that
does not require Arrow and its dependencies to be available in the runtime environment.
the following cmake options to the libcudf build:
```
-DCUDF_LARGE_STRINGS_DISABLED=ON -DCUDF_USE_ARROW_STATIC=ON -DCUDF_ENABLE_ARROW_S3=OFF
```
These options:
- Disable large string support, see https://github.com/rapidsai/cudf/issues/16215
- Statically link Arrow to libcudf to remove Arrow as a runtime dependency.

After building libcudf, the Java bindings can be built via Maven, e.g.:
```
Expand Down
3 changes: 2 additions & 1 deletion java/ci/build-in-docker.sh
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/bin/bash

#
# Copyright (c) 2020-2023, NVIDIA CORPORATION. All rights reserved.
# Copyright (c) 2020-2024, NVIDIA CORPORATION. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -58,6 +58,7 @@ cmake .. -G"${CMAKE_GENERATOR}" \
-DCMAKE_INSTALL_PREFIX=$INSTALL_PREFIX \
-DCUDA_STATIC_RUNTIME=$ENABLE_CUDA_STATIC_RUNTIME \
-DUSE_NVTX=$ENABLE_NVTX \
-DCUDF_LARGE_STRINGS_DISABLED=ON \
-DCUDF_USE_ARROW_STATIC=ON \
-DCUDF_ENABLE_ARROW_S3=OFF \
-DBUILD_TESTS=$BUILD_CPP_TESTS \
Expand Down

0 comments on commit cc8c868

Please sign in to comment.