Skip to content

Commit

Permalink
xfail pytorch test and move integration tests out of cudf_pandas_tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Matt711 committed Aug 27, 2024
1 parent 8443f55 commit 8ffbc2f
Show file tree
Hide file tree
Showing 26 changed files with 9 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -239,12 +239,12 @@ jobs:
arch: "amd64"
container_image: "rapidsai/ci-conda:latest"
run_script: |
LIBS=$(python/cudf/cudf_pandas_tests/third_party_integration_tests/ci/extract_lib.sh python/cudf/cudf_pandas_tests/third_party_integration_tests/dependencies.yaml)
LIBS=$(python/cudf/cudf_pandas_third_party_integration_tests/ci/extract_lib.sh python/cudf/cudf_pandas_third_party_integration_tests/dependencies.yaml)
LIBS=${LIBS#[}
LIBS=${LIBS%]}
for lib in ${LIBS//,/ }; do
lib=$(echo "$lib" | tr -d '""')
echo "Running tests for $lib"
CUDA_MAJOR=$(if [ "$lib" = "tensorflow" ]; then echo "11"; else echo "12"; fi)
python/cudf/cudf_pandas_tests/third_party_integration_tests/ci/test.sh $lib $CUDA_MAJOR
python/cudf/cudf_pandas_third_party_integration_tests/ci/test.sh $lib $CUDA_MAJOR
done
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -134,12 +134,12 @@ jobs:
sha: ${{ inputs.sha }}
container_image: "rapidsai/ci-conda:latest"
run_script: |
LIBS=$(python/cudf/cudf_pandas_tests/third_party_integration_tests/ci/extract_lib.sh python/cudf/cudf_pandas_tests/third_party_integration_tests/dependencies.yaml)
LIBS=$(python/cudf/cudf_pandas_third_party_integration_tests/ci/extract_lib.sh python/cudf/cudf_pandas_third_party_integration_tests/dependencies.yaml)
LIBS=${LIBS#[}
LIBS=${LIBS%]}
for lib in ${LIBS//,/ }; do
lib=$(echo "$lib" | tr -d '""')
echo "Running tests for $lib"
CUDA_MAJOR=$(if [ "$lib" = "tensorflow" ]; then echo "11"; else echo "12"; fi)
python/cudf/cudf_pandas_tests/third_party_integration_tests/ci/test.sh $lib $CUDA_MAJOR
python/cudf/cudf_pandas_third_party_integration_tests/ci/test.sh $lib $CUDA_MAJOR
done
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ set -euo pipefail

rapids-logger "Generate Python testing dependencies"
rapids-dependency-file-generator \
--config "python/cudf/cudf_pandas_tests/third_party_integration_tests/dependencies.yaml" \
--config "python/cudf/cudf_pandas_third_party_integration_tests/dependencies.yaml" \
--output conda \
--file-key test_${LIB} \
--matrix "cuda=${RAPIDS_CUDA_VERSION%.*};arch=$(arch);py=${RAPIDS_PY_VERSION}" | tee env.yaml
Expand All @@ -28,7 +28,7 @@ echo "The working directory is ${PWD}"
mkdir -p "${RAPIDS_TESTS_DIR}"

repo_root=$(git rev-parse --show-toplevel)
TEST_DIR=${repo_root}/python/cudf/cudf_pandas_tests/third_party_integration_tests/tests
TEST_DIR=${repo_root}/python/cudf/cudf_pandas_third_party_integration_tests/tests

rapids-print-env

Expand All @@ -51,7 +51,7 @@ for serial_library in "${serial_libraries[@]}"; do
fi
done

RAPIDS_TESTS_DIR=${RAPIDS_TESTS_DIR} TEST_DIR=${TEST_DIR} NUM_PROCESSES=${NUM_PROCESSES} python/cudf/cudf_pandas_tests/third_party_integration_tests/ci/ci_run_library_tests.sh ${LIB}
RAPIDS_TESTS_DIR=${RAPIDS_TESTS_DIR} TEST_DIR=${TEST_DIR} NUM_PROCESSES=${NUM_PROCESSES} python/cudf/cudf_pandas_third_party_integration_tests/ci/ci_run_library_tests.sh ${LIB}

rapids-logger "Test script exiting with value: ${EXITCODE}"
exit ${EXITCODE}
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ def test_torch_tensor_ctor():
return torch.tensor(s.values)


@pytest.mark.xfail_cudf_pandas(reason="Known failure, see xdf/#210")
@pytest.mark.xfail_compare
def test_torch_tensor_from_numpy():
s = pd.Series(range(5))
return torch.from_numpy(s.values)

0 comments on commit 8ffbc2f

Please sign in to comment.