code review

rapidsai · Oct 10, 2024 · 80dc0e5 · 80dc0e5
1 parent 483ce19
commit 80dc0e5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/cpp/include/cudf/detail/device_scalar.hpp b/cpp/include/cudf/detail/device_scalar.hpp
@@ -35,6 +35,8 @@ class device_scalar : public rmm::device_scalar<T> {
 #endif
   ~device_scalar() = default;
 
+// Implementation is the same as what compiler should generate
+// Could not use default move constructor as 11.8 compiler fails to generate it
 #ifdef __CUDACC__
 #pragma nv_exec_check_disable
 #endif

diff --git a/cpp/src/join/distinct_hash_join.cu b/cpp/src/join/distinct_hash_join.cu
@@ -17,7 +17,6 @@
 #include "join_common_utils.hpp"
 
 #include <cudf/detail/cuco_helpers.hpp>
-#include <cudf/detail/device_scalar.hpp>
 #include <cudf/detail/distinct_hash_join.cuh>
 #include <cudf/detail/nvtx/ranges.hpp>
 #include <cudf/detail/utilities/cuda.cuh>