Some cleanup

rapidsai · Sep 25, 2023 · 33de8d4 · 33de8d4
1 parent b11fc0a
commit 33de8d4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/python/cudf/cudf/_lib/scalar.pxd b/python/cudf/cudf/_lib/scalar.pxd
@@ -5,6 +5,9 @@ from libcpp.memory cimport unique_ptr
 
 from rmm._lib.memory_resource cimport DeviceMemoryResource
 
+# TODO: Would like to remove this cimport, but it will require some more work
+# to excise all C code in scalar.pyx that relies on using the C API of the
+# pylibcudf Scalar underlying the DeviceScalar.
 from cudf._lib cimport pylibcudf
 from cudf._lib.cpp.scalar.scalar cimport scalar
 

diff --git a/python/cudf/cudf/_lib/scalar.pyx b/python/cudf/cudf/_lib/scalar.pyx
@@ -166,10 +166,6 @@ cdef class DeviceScalar:
         _replace_nested(ret, lambda item: item is None, NA)
         return ret
 
-    # TODO: This is just here for testing and should be removed.
-    def get(self):
-        return self.c_value
-
     @property
     def dtype(self):
         """