Skip to content

Commit

Permalink
Merge branch 'branch-24.10' of github.com:rapidsai/cudf into libcudf-…
Browse files Browse the repository at this point in the history
…wheel
  • Loading branch information
jameslamb committed Aug 12, 2024
2 parents 06474bd + e5f8dd3 commit 16bfed1
Show file tree
Hide file tree
Showing 24 changed files with 357 additions and 261 deletions.
1 change: 0 additions & 1 deletion cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,6 @@ add_library(
src/io/csv/reader_impl.cu
src/io/csv/writer_impl.cu
src/io/functions.cpp
src/io/json/byte_range_info.cu
src/io/json/json_column.cu
src/io/json/json_normalization.cu
src/io/json/json_tree.cu
Expand Down
4 changes: 2 additions & 2 deletions cpp/include/cudf/io/detail/json.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ void write_json(data_sink* sink,
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Device memory resource to use for device memory allocation
*/
void normalize_single_quotes(datasource::owning_buffer<rmm::device_uvector<char>>& indata,
void normalize_single_quotes(datasource::owning_buffer<rmm::device_buffer>& indata,
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr);

Expand All @@ -72,7 +72,7 @@ void normalize_single_quotes(datasource::owning_buffer<rmm::device_uvector<char>
* @param stream CUDA stream used for device memory operations and kernel launches
* @param mr Device memory resource to use for device memory allocation
*/
void normalize_whitespace(datasource::owning_buffer<rmm::device_uvector<char>>& indata,
void normalize_whitespace(datasource::owning_buffer<rmm::device_buffer>& indata,
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr);
} // namespace io::json::detail
Expand Down
12 changes: 0 additions & 12 deletions cpp/include/cudf/strings/replace.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -160,18 +160,6 @@ std::unique_ptr<column> replace_multiple(
rmm::cuda_stream_view stream = cudf::get_default_stream(),
rmm::device_async_resource_ref mr = rmm::mr::get_current_device_resource());

/**
* @copydoc cudf::strings::replace_multiple
*
* @deprecated since 24.08
*/
[[deprecated]] std::unique_ptr<column> replace(
strings_column_view const& input,
strings_column_view const& targets,
strings_column_view const& repls,
rmm::cuda_stream_view stream = cudf::get_default_stream(),
rmm::device_async_resource_ref mr = rmm::mr::get_current_device_resource());

/** @} */ // end of doxygen group
} // namespace strings
} // namespace CUDF_EXPORT cudf
19 changes: 0 additions & 19 deletions cpp/include/cudf/utilities/type_checks.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,6 @@

namespace CUDF_EXPORT cudf {

/**
* @brief Compare the types of two `column_view`s
*
* @deprecated Since 24.06. Use cudf::have_same_types instead.
*
* This function returns true if the type of `lhs` equals that of `rhs`.
* - For fixed point types, the scale is compared.
* - For dictionary types, the type of the keys are compared if both are
* non-empty columns.
* - For lists types, the type of child columns are compared recursively.
* - For struct types, the type of each field are compared in order.
* - For all other types, the `id` of `data_type` is compared.
*
* @param lhs The first `column_view` to compare
* @param rhs The second `column_view` to compare
* @return true if column types match
*/
[[deprecated]] bool column_types_equal(column_view const& lhs, column_view const& rhs);

/**
* @brief Compare the type IDs of two `column_view`s
*
Expand Down
37 changes: 0 additions & 37 deletions cpp/src/io/json/byte_range_info.cu

This file was deleted.

20 changes: 10 additions & 10 deletions cpp/src/io/json/json_normalization.cu
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ struct TransduceToNormalizedWS {

namespace detail {

void normalize_single_quotes(datasource::owning_buffer<rmm::device_uvector<SymbolT>>& indata,
void normalize_single_quotes(datasource::owning_buffer<rmm::device_buffer>& indata,
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr)
{
Expand All @@ -311,22 +311,22 @@ void normalize_single_quotes(datasource::owning_buffer<rmm::device_uvector<Symbo
normalize_quotes::TransduceToNormalizedQuotes{}),
stream);

rmm::device_uvector<SymbolT> outbuf(indata.size() * 2, stream, mr);
rmm::device_buffer outbuf(indata.size() * 2, stream, mr);
rmm::device_scalar<SymbolOffsetT> outbuf_size(stream, mr);
parser.Transduce(indata.data(),
parser.Transduce(reinterpret_cast<SymbolT const*>(indata.data()),
static_cast<SymbolOffsetT>(indata.size()),
outbuf.data(),
static_cast<SymbolT*>(outbuf.data()),
thrust::make_discard_iterator(),
outbuf_size.data(),
normalize_quotes::start_state,
stream);

outbuf.resize(outbuf_size.value(stream), stream);
datasource::owning_buffer<rmm::device_uvector<SymbolT>> outdata(std::move(outbuf));
datasource::owning_buffer<rmm::device_buffer> outdata(std::move(outbuf));
std::swap(indata, outdata);
}

void normalize_whitespace(datasource::owning_buffer<rmm::device_uvector<SymbolT>>& indata,
void normalize_whitespace(datasource::owning_buffer<rmm::device_buffer>& indata,
rmm::cuda_stream_view stream,
rmm::device_async_resource_ref mr)
{
Expand All @@ -339,18 +339,18 @@ void normalize_whitespace(datasource::owning_buffer<rmm::device_uvector<SymbolT>
normalize_whitespace::TransduceToNormalizedWS{}),
stream);

rmm::device_uvector<SymbolT> outbuf(indata.size(), stream, mr);
rmm::device_buffer outbuf(indata.size(), stream, mr);
rmm::device_scalar<SymbolOffsetT> outbuf_size(stream, mr);
parser.Transduce(indata.data(),
parser.Transduce(reinterpret_cast<SymbolT const*>(indata.data()),
static_cast<SymbolOffsetT>(indata.size()),
outbuf.data(),
static_cast<SymbolT*>(outbuf.data()),
thrust::make_discard_iterator(),
outbuf_size.data(),
normalize_whitespace::start_state,
stream);

outbuf.resize(outbuf_size.value(stream), stream);
datasource::owning_buffer<rmm::device_uvector<SymbolT>> outdata(std::move(outbuf));
datasource::owning_buffer<rmm::device_buffer> outdata(std::move(outbuf));
std::swap(indata, outdata);
}

Expand Down
Loading

0 comments on commit 16bfed1

Please sign in to comment.