Apply suggestions from code reviews.

rapidsai · Sep 17, 2024 · 135d565 · 135d565
1 parent c5e81fe
commit 135d565
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/cpp/include/cudf/io/parquet.hpp b/cpp/include/cudf/io/parquet.hpp
@@ -39,7 +39,7 @@ namespace io {
  * @file
  */
 
-constexpr auto default_row_group_size_bytes =
+constexpr size_t default_row_group_size_bytes =
   std::numeric_limits<size_t>::max();                          ///< Infinite bytes per row group
 constexpr size_type default_row_group_size_rows = 1'000'000;   ///< 1 million rows per row group
 constexpr size_t default_max_page_size_bytes    = 512 * 1024;  ///< 512KB per page

diff --git a/cpp/src/io/parquet/writer_impl.cu b/cpp/src/io/parquet/writer_impl.cu
@@ -1825,7 +1825,8 @@ auto convert_table_to_parquet_data(table_input_metadata& table_meta,
         std::min<size_t>(std::numeric_limits<size_type>::max(),
                          util::div_rounding_up_safe(max_row_group_size, avg_row_len));
       // Safe comparison as rg_frag_size fits in size_type
-      max_page_fragment_size = std::min<size_type>(rg_frag_size, max_page_fragment_size);
+      max_page_fragment_size =
+        std::min<size_type>(static_cast<size_type>(rg_frag_size), max_page_fragment_size);
     }
 
     // dividing page size by average row length will tend to overshoot the desired