Skip to content
This repository has been archived by the owner on Mar 25, 2024. It is now read-only.

OpenStack: support lbaas classes (FIP subnet IDs) #986

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kayrus
Copy link

@kayrus kayrus commented Sep 24, 2019

Part of the rancher/rancher#23020

@kayrus
Copy link
Author

kayrus commented Sep 27, 2019

@dramich could you please assign someone on this PR?

@kayrus
Copy link
Author

kayrus commented Oct 1, 2019

@alena1108 could you please assign someone on this PR?

@kayrus
Copy link
Author

kayrus commented Oct 14, 2019

@dramich @alena1108 kindly ping

Copy link
Contributor

@daxmc99 daxmc99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please reach out to me in the rancher slack developer channel. For types changes we typically require an equivalent change in RKE/Rancher with a go.mod replace directive such that the changes can run against our CI.

// DeepCopyInto is an autogenerated deepcopy function, copying the receiver, writing into out. in must be non-nil.
func (in *LoadBalancerOpenstackOpts) DeepCopyInto(out *LoadBalancerOpenstackOpts) {
*out = *in
if in.LBClasses != nil {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated code and this looks like a hand edit. This will be overwritten.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, this is a generated code

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants