Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cisnetworkpolicy finalizer when controller is disabled #5856

Merged

Conversation

brandond
Copy link
Member

Proposed Changes

Remove cisnetworkpolicy finalizer when controller is disabled

Prevents blocking node deletion after upgrading from a release that previously ran this controller, but no longer does due to the controller not being enabled for the configured CNI.

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change

Further Comments

@brandond brandond requested a review from a team as a code owner April 26, 2024 19:47
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes are missing coverage. Please review.

Project coverage is 26.09%. Comparing base (8b577f6) to head (0138abe).
Report is 1 commits behind head on master.

Files Patch % Lines
pkg/controllers/cisnetworkpolicy/cleanup.go 0.00% 35 Missing ⚠️
pkg/rke2/rke2.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5856      +/-   ##
==========================================
- Coverage   26.46%   26.09%   -0.37%     
==========================================
  Files          30       31       +1     
  Lines        2649     2686      +37     
==========================================
  Hits          701      701              
- Misses       1903     1940      +37     
  Partials       45       45              
Flag Coverage Δ
inttests 9.86% <0.00%> (-0.14%) ⬇️
unittests 18.54% <0.00%> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants