Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iam:TagRole to minimum EKS permissions #1578

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

mjura
Copy link
Contributor

@mjura mjura commented Nov 25, 2024

Fixes #[issue_number]

Reminders

  • See the README for more details on how to work with the Rancher docs.

  • Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.

  • If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.

Description

Comments

Copy link
Contributor

@sunilarjun sunilarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mjura! Approving the content addition to /docs however before officially approving the PR this content would also need to be applied to the 2.10/2.9/2.8 versioned docs as well. Would you be able to apply the updated content to those versions? If not I can assist with porting them to the relevant versions. Please let me know if you have any questions, thank you!

yiannistri
yiannistri previously approved these changes Nov 26, 2024
Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Bonus points for ordering them alphabetically 🙏

@mjura
Copy link
Contributor Author

mjura commented Nov 26, 2024

Thank you @mjura! Approving the content addition to /docs however before officially approving the PR this content would also need to be applied to the 2.10/2.9/2.8 versioned docs as well. Would you be able to apply the updated content to those versions? If not I can assist with porting them to the relevant versions. Please let me know if you have any questions, thank you!

Could you please tell me how or to which branches I should submit backport of this change.

@sunilarjun
Copy link
Contributor

Hello @mjura, the following files would need the changes applied and noting the paths below:

versioned_docs/version-2.10/how-to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-clusters-from-hosted-kubernetes-providers/eks.md
versioned_docs/version-2.9/how-to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-clusters-from-hosted-kubernetes-providers/eks.md
versioned_docs/version-2.8/how-to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-clusters-from-hosted-kubernetes-providers/eks.md

Let me know if any clarification is needed, thank you.

@mjura
Copy link
Contributor Author

mjura commented Nov 28, 2024

Hello @mjura, the following files would need the changes applied and noting the paths below:

versioned_docs/version-2.10/how-to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-clusters-from-hosted-kubernetes-providers/eks.md versioned_docs/version-2.9/how-to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-clusters-from-hosted-kubernetes-providers/eks.md versioned_docs/version-2.8/how-to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-clusters-from-hosted-kubernetes-providers/eks.md

Let me know if any clarification is needed, thank you.

Thank you, I have backported this change to v2.10, v2.9 and v2.8.

Please review and let's merge it.

Copy link
Contributor

@yiannistri yiannistri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mjura
Copy link
Contributor Author

mjura commented Nov 28, 2024

@sunilarjun I think we can merge it now

Copy link
Contributor

@sunilarjun sunilarjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing the changes!

@sunilarjun sunilarjun merged commit 38204c2 into main Dec 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants