-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iam:TagRole to minimum EKS permissions #1578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @mjura! Approving the content addition to /docs
however before officially approving the PR this content would also need to be applied to the 2.10/2.9/2.8
versioned docs as well. Would you be able to apply the updated content to those versions? If not I can assist with porting them to the relevant versions. Please let me know if you have any questions, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Bonus points for ordering them alphabetically 🙏
5e2c836
to
b626c2e
Compare
Could you please tell me how or to which branches I should submit backport of this change. |
Hello @mjura, the following files would need the changes applied and noting the paths below: versioned_docs/version-2.10/how-to-guides/new-user-guides/kubernetes-clusters-in-rancher-setup/set-up-clusters-from-hosted-kubernetes-providers/eks.md Let me know if any clarification is needed, thank you. |
b626c2e
to
a6536b8
Compare
a6536b8
to
8e10fcd
Compare
Thank you, I have backported this change to v2.10, v2.9 and v2.8. Please review and let's merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@sunilarjun I think we can merge it now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing the changes!
Fixes #[issue_number]
Reminders
See the README for more details on how to work with the Rancher docs.
Verify if changes pertain to other versions of Rancher. If they do, finalize the edits on one version of the page, then apply the edits to the other versions.
If the pull request is dependent on an upcoming release, remember to add a "MERGE ON RELEASE" label and set the proper milestone.
Description
Comments