Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding per logging overrides #4478

Open
wants to merge 2 commits into
base: dev-v2.9
Choose a base branch
from

Conversation

gregsidelinger
Copy link

Issue:

Problem

The rancher-logging chart is very inflexible in per logging tweaks. There is generic overlay to change settings not exposed by the chart.

Solution

Added two new keys loggingOverlays and fluentbitAgentOverlays to the values that allows per logging overlays per logger.

Testing

Engineering Testing

Manual Testing

Deploying with a values like this allows me to scale up the fluentd replicas for root logger only.

loggingOverlays:
  root:
   spec:
    fluentd:
      scaling:
        replicas: 6

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

Signed-off-by: Greg Sidelinger <[email protected]>
Signed-off-by: Greg Sidelinger <[email protected]>
@gregsidelinger gregsidelinger requested a review from a team as a code owner September 23, 2024 19:24
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant