Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change order of applying changes #683

Closed
wants to merge 1 commit into from
Closed

Change order of applying changes #683

wants to merge 1 commit into from

Conversation

vatsalparekh
Copy link
Contributor

@vatsalparekh vatsalparekh commented Oct 8, 2024 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes
Issue #667

Special notes for your reviewer:

Checklist:

  • squashed commits into logical changes
  • includes documentation
  • adds unit tests
  • adds or updates e2e tests
  • backport needed

@mjura
Copy link
Contributor

mjura commented Oct 9, 2024

It is not changing the order of some actions, you are moving the whole part under

	// check addon monitoring
	if config.Spec.Monitoring != nil {

section

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vatsalparekh @mjura