Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screener tweaks #2168

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Conversation

ericpien
Copy link
Contributor

@ericpien ericpien commented Dec 4, 2024

- Setting Body to Screener returns the Screener Object to enable method chaining. (i.e. `r = yf.Screener().set_predefined_body("day_gainers").response`)
- Limit query size to 250 and raise error if larger. This also avoids unnecessary network calls and makes the issue clearer.
@ericpien ericpien marked this pull request as ready for review December 4, 2024 20:50
@ValueRaider ValueRaider merged commit f526464 into ranaroussi:dev Dec 5, 2024
2 checks passed
@ValueRaider
Copy link
Collaborator

When you say Setting Body to Screener returns the Screener object, do you mean Screener.set_predefined_body() returns the Screener object?

@ericpien
Copy link
Contributor Author

ericpien commented Dec 6, 2024

When you say Setting Body to Screener returns the Screener object, do you mean Screener.set_predefined_body() returns the Screener object?

Yes, and any other functions that set the body: set_default_body(), set_predefined_body(), set_body(), patch_body() so user can chain methods right after setting the body.

@ValueRaider ValueRaider mentioned this pull request Dec 17, 2024
@ValueRaider ValueRaider changed the title Update Screener Screener tweaks Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants