Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/insider roster #1728

Closed
wants to merge 1 commit into from

Conversation

lauchunhin
Copy link

@lauchunhin lauchunhin commented Oct 19, 2023

Added a new method to access the insider roster from the site. This enhancement provides users with the ability to retrieve insider roster information, which was previously unavailable.
Resolves #1529

@lauchunhin lauchunhin changed the title Feature/insider roster #1529 Feature/insider roster Oct 19, 2023
@bot-unit
Copy link

bot-unit commented Dec 2, 2023

@ValueRaider we can get this data with my changes to quote.py. It's modules of quote summary: insiderTransactions, insiderHolders, majorDirectHolders
So if it is needed, i can add code to quote.py and than discuss with you, how move parsing from quote.py to other place.

@ValueRaider
Copy link
Collaborator

ValueRaider commented Dec 2, 2023

@bot-unit Implement in/after the refactor.

@ValueRaider
Copy link
Collaborator

@lauchunhin I think best way to resolve conflict is avoid - move self.insider = Insider(self.data) to bottom, then Git might be able to merge cleanly.

Then add a unit test.

@bot-unit
Copy link

@ValueRaider Close, please. Implemented at #1772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants