Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix slackbot issues with double quotes #511

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

gordlin
Copy link
Member

@gordlin gordlin commented Nov 29, 2024

Changes

  • [FIX] Replaces double quotes (") with single quotes (') within the slackbot summary to prevent the string and the bot from breaking.

This change is Reviewable

@gordlin gordlin added the PR: Build PR that involves changes to the build. This includes changes to the Github Actions. For JS wizards. label Nov 29, 2024
@gordlin gordlin requested a review from szczz November 29, 2024 18:52
Copy link

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @gordlin)

@szczz szczz merged commit 70a41e0 into ramp4-pcar4:main Nov 29, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Build PR that involves changes to the build. This includes changes to the Github Actions. For JS wizards.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants