Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caption for chart panels #507

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Nov 21, 2024

Related Item(s)

ramp4-pcar4/storylines-editor#393

Changes

  • Added captions for chart panels

Testing

Steps:

  1. Open the demo page
  2. Navigate to the dynamic panel with title This Slide Is Dynamic!
  3. Open the charts panel
  4. Observe the caption under each chart of the slideshow
  5. Navigate to the Highcharts Demo slide
  6. Observe the caption under each chart of the slideshow

This change is Reviewable

@IshavSohal IshavSohal added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Nov 21, 2024
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please exclude the package-lock.json file from PR

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

@IshavSohal IshavSohal changed the title Add caption for chart panels, update dependancies Add caption for chart panels Nov 22, 2024
Copy link
Member Author

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Donethanks

Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the current implementation, the caption won't be visible if there's a single chart on a slide with a background image:

image.png

The solution we use for the image panel should work here as well. You should also add the text-sm class to the caption so it's consistent with the other captions.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

Copy link
Member Author

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Donethanks

Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 4 files at r1, 1 of 1 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

@yileifeng yileifeng merged commit 20a17a9 into ramp4-pcar4:main Dec 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants