Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add captions to map panels; adjust map layout to better fit titles and captions #505

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

RyanCoulsonCA
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA commented Nov 15, 2024

Related Item(s)

#503

Changes

  • Added the caption property to map panels. When provided, the caption will appear under the map as it does for images and slideshows.
  • Adjusted the structure of the map panel:
    • Instead of hardcoding the map height based on whether there's a horizontal or vertical ToC, and based on whether there's a title or not, the height of the entire panel is now simply based on the ToC orientation.
    • Within the panel, the title and caption will take up as much space as required and the map will simply fill in the rest of the available space.
  • Point of interest titles now support HTML
  • Removed self-start property from slideshow children. Elements should now appear in the center of the slideshow component.

Testing

Steps:

  1. Open the demo page.
  2. I've added a new slideshow containing 4 maps with different scenarios (just under the interactive map panel, the text panel accompanying it is titled RAMP4 Test). Ensure that these are rendering correctly on desktop and mobile.

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/fix-503/#/en/00000000-0000-0000-0000-000000000000

@RyanCoulsonCA RyanCoulsonCA added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Nov 15, 2024
Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@RyanCoulsonCA
Copy link
Member Author

Added an extra fix to this PR for https://github.com/ramp4-pcar4/tcei-tmx-cwa-storylines/issues/96:

  • Point of interest titles now support HTML

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@RyanCoulsonCA
Copy link
Member Author

Aaaand one more addition:

  • Removed self-start property from slideshow children. Elements should now appear in the center of the slideshow component:

Before:
image

After:
image

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 6 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @RyanCoulsonCA)

@yileifeng yileifeng merged commit 4731e4a into ramp4-pcar4:main Nov 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants