-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include the full discovery url on invalid HTTP response #142
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 51.84% 51.76% -0.08%
==========================================
Files 16 16
Lines 2145 2148 +3
==========================================
Hits 1112 1112
- Misses 1033 1036 +3 ☔ View full report in Codecov by Sentry. |
Thanks for the PR! I'll merge once CI passes (looks like |
O yes sorry :) |
I had tried running it and it failed so I invalidly concluded that you did not use it. But I'm a bit of a rust noob so not sure of the best practices :). |
Thanks!
When I run it locally with Cargo/Rust 1.71.0 (
I think this file is mainly for pinning to specific versions: https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file. |
This is now released in 3.5.0. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [openidconnect](https://togithub.com/ramosbugs/openidconnect-rs) | dependencies | minor | `3.4.0` -> `3.5.0` | --- ### Release Notes <details> <summary>ramosbugs/openidconnect-rs (openidconnect)</summary> ### [`v3.5.0`](https://togithub.com/ramosbugs/openidconnect-rs/releases/tag/3.5.0) [Compare Source](https://togithub.com/ramosbugs/openidconnect-rs/compare/3.4.0...3.5.0) #### New Features - Add `UserInfoRequest::set_response_type` by [@​FabianLars](https://togithub.com/FabianLars) in [https://github.com/ramosbugs/openidconnect-rs/pull/146](https://togithub.com/ramosbugs/openidconnect-rs/pull/146) #### Bug Fixes - Remove `#[non_exhaustive]` from `LogoutProviderMetadata` ([#​150](https://togithub.com/ramosbugs/openidconnect-rs/issues/150)) - Include the full discovery url on invalid HTTP response by [@​Timshel](https://togithub.com/Timshel) in [https://github.com/ramosbugs/openidconnect-rs/pull/142](https://togithub.com/ramosbugs/openidconnect-rs/pull/142) **Full Changelog**: ramosbugs/openidconnect-rs@3.4.0...3.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 9pm,before 6am" in timezone Europe/Zurich, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/smartive/zitadel-rust). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOTEuMCIsInVwZGF0ZWRJblZlciI6IjM3LjE5MS4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Hey,
Simple PR to add the full discovery url to the error since in lot of cases it will be due to an improper
issuer_url
.