reqwest: Migrate to shared Error type and use thiserror's From impl
#238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…impl `reqwest` no longer has a separate error type for sync and async implementations. In addition `thiserror` can generate `From` implementations for automatic conversions in the `Try` (`?`) operator. Finally, delete some unnecessary `#[cfg]` wraps that are already guarding the module as a whole, and that the code won't compile without anyway.
MarijnS95
force-pushed
the
reqwest-unify-error-types
branch
from
af16d4d to
b02f9cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reqwestno longer has a separate error type for sync and async implementations. In additionthiserrorcan generateFromimplementations for automatic conversions in theTry(?) operator.Finally, delete some unnecessary
#[cfg]wraps that are already guarding the module as a whole, and that the code won't compile without anyway.