Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update classic-taskbar-buttons-lite.wh.cpp #870

Merged
merged 2 commits into from
Aug 17, 2024
Merged

Conversation

Anixx
Copy link
Contributor

@Anixx Anixx commented Aug 17, 2024

Fix for artefacts

@m417z
Copy link
Member

m417z commented Aug 17, 2024

Please rename the hooks variable according to the instructions while at it. For example, you can rename it to explorerExeHooks.

@Anixx
Copy link
Contributor Author

Anixx commented Aug 17, 2024

Done

@m417z m417z merged commit 566fb1c into ramensoftware:main Aug 17, 2024
5 checks passed
@levitation
Copy link
Contributor

levitation commented Aug 18, 2024

@Anixx Now that you made the adjustments to your mod, my workaround to your mod's previous version causes reverse artefacts - The buttons appear slightly flatter than they should. Fortunately it is not glaringly visible, so users may not notice it.

In other words, the workaround I created during our long conversation is no longer necessary and even backfires a bit.

There is also no way for my mod to know with reasonable effort whether the user is using older or newer version of your mod. For time being, I will keep my workaround to your mod's old version active.

@levitation
Copy link
Contributor

levitation commented Aug 18, 2024

@Anixx Do I get it right that you actually liked the bigger spacing between Taskbar buttons you had in the earlier version of the mod? And now some other incompatibility than my mod caused you to remove the spacing?

If so, then maybe you could actually keep the spacing, if you first paint the button area with taskbar background colour using FillRect(), then change the offsets as you did in the earlier version of your mod, and then finally render the button with DrawFrameControl() ? In other words, keep the old code, but introduce FillRect() as a first step before offset change.

Curious, how does that sound to you?

The main potential benefit is that you can still have the button spacing and hopefully solve incompatibility with other software. And secondary benefit would be that my mod does not need to guess whether your mod changed the offsets or not, since you keep the old behaviour of changing the offsets.

@Anixx
Copy link
Contributor Author

Anixx commented Aug 18, 2024

@levitation the spacing is the same, not changed.

@levitation
Copy link
Contributor

levitation commented Aug 18, 2024

@Anixx Thank you for letting me know. Indeed, I need to restart Taskbar process to see the spaces, otherwise they disappear upon the activation of your mod.

There is one more nuance, the spacing is visible only between buttons of different programs. If there is a group of buttons from multiple instances of same program, then these buttons now do not have spacing. For example, if you launch Notepad multiple times.

Is that how you intended it to be? Then I know that if I change my mod accordingly (by removing the now unnecessary compatibility code), then it is a purposeful work.

@Anixx
Copy link
Contributor Author

Anixx commented Aug 18, 2024

It is how Windows intends it to be. If one dislikes different spaces, he can disable groupping (for instance, in 7+TT) or installing the "Disable groupping" mod.

@levitation
Copy link
Contributor

@Anixx Understood, I will then consider that you will keep this grouping option active (unless user disables it via 7+TT or by other means). Thank you again for responding and letting me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants