Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Explorerframe fixes for Win11 22H2+ #864

Merged
merged 3 commits into from
Aug 15, 2024

Conversation

CyprinusCarpio
Copy link
Contributor

This mod fixes a couple of issues with File Explorer windows appearance in Windows 11 releases 22H2, 23H2 and 24H2.

Unpredictable menu bar appearance: On Windows 11 22H2 and 23H2, the menu bar may appear unpredictably. This mod allows the user to disable the menu bar entirely, or have it be shown at all times.
You can force show/hide the menu bar in the mod settings. Forcing the menu bar to be shown is intended for the Classic theme.

Delay on navigation to a new folder when using SysListView32: this is caused by a extra erroneous message sent to the list view window. This mod supresses it, fixing the problem.

Black artifacts briefly visible in new file explorer windows under Classic theme: this is caused by incorrect handling of WM_ERASEBKGND in CabinetWClass window procedure. This mod adds a option to correct this.

Changes will be visible in new file explorer windows.

@CyprinusCarpio
Copy link
Contributor Author

There seems to be some issue with the hook variable names. This check wasn't there when I last did PR's. Tried to fix it, but it seems like there's still some problem.

Anyways, so as not to clutter the Discord bot message, I'll add some more info about the mod here so it can be better considered.
Classic theme users reported a few issues with file explorer window behaviour and appearance starting with Win 11 22H2, and the only available fix for that was replacing explorerframe.dll with the one from 21H2. Obviously this is less than optimal. Moreover, this mod also caters to generic 22H2 and 23H2 users, that want to get rid of the menu bar completely. For some reason the menu bar may appear when the screen resolution is changed, or randomly after some time has passed (appears to be fixed in 24H2).

The biggest concern about this mod is that it guts WM_SETREDRAW functionality for the SysListView32 in order to fix the visual delay on navigation to new folders and when opening a new window. During my testing it appears that this doesn't have any perceivable ill effects.

@m417z m417z merged commit 441cbdf into ramensoftware:main Aug 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants