Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Qt scrollbar grippers 1.0 #836

Merged
merged 2 commits into from
Aug 3, 2024
Merged

Fix Qt scrollbar grippers 1.0 #836

merged 2 commits into from
Aug 3, 2024

Conversation

kawapure
Copy link
Contributor

@kawapure kawapure commented Aug 3, 2024

No description provided.

@kawapure
Copy link
Contributor Author

kawapure commented Aug 3, 2024

The check failed because the Twitter handle "requires manual verification" - I can verify my ownership of the account by any means necessary if they would be provided, or the field can removed.

image

@m417z
Copy link
Member

m417z commented Aug 3, 2024

Please send me (https://twitter.com/m417z) a direct message with the following content:

I attest that I'm the sole owner of both this Twitter account (https://twitter.com/kawaipure) and the following GitHub account: https://github.com/kawapure

@kawapure
Copy link
Contributor Author

kawapure commented Aug 3, 2024

Done!

// @github https://github.com/kawapure
// @twitter https://twitter.com/kawaipure
// @homepage https://kawapure.github.io
// @include ida64.exe
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was it meant to only target IDA?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDA was the application that I tested against, but it should work for any Qt 6.1+ application using native theme scrollbar controls. I thought that it would be obvious to any end user to specify custom targets. Should this be clarified in the README?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, better clarify it, something like:

## How to enable the mod for a program
In Windhawk, go to the "Advanced" tab and scroll down to
"Custom process inclusion list". In that box, put the filename of the `.exe`.
The mod will immediately apply to those programs after you click "Save".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied that clarification.

@m417z m417z merged commit ad2ad2e into ramensoftware:main Aug 3, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants