Update "Accent Color Sync" #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m417z
reviewed
Jul 21, 2024
mods/accent-color-sync.wh.cpp
Outdated
| void ColorFunction(BOOL force = false) | ||
| { | ||
| if (!isWorking) | ||
| WindhawkUtils::SYMBOL_HOOK hooks[] = { |
There was a problem hiding this comment.
Have you seen the warning for this line? I added a new rule for naming symbol hook variables, to be able to optimize loading symbols. Let me know if the message is not clear enough.
There was a problem hiding this comment.
I saw it, but actually didn't understand what it was supposed to mean at first until after scanning through it this morning. It should be fixed now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewritten almost completely so that it now requires the OpenGlass Legacy edition (source code, fork), among other updates