Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Shutdown Dialog 1.0.0 #360

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Custom Shutdown Dialog 1.0.0 #360

merged 3 commits into from
Nov 5, 2023

Conversation

aubymori
Copy link
Contributor

@aubymori aubymori commented Nov 5, 2023

Override the classic shutdown dialog in Explorer which is invoked with ALT+F4 with your own program.

@aubymori
Copy link
Contributor Author

aubymori commented Nov 5, 2023

Should be good to go now.

@m417z
Copy link
Member

m417z commented Nov 5, 2023

Why not WindhawkUtils::StringSetting? It was created just for these cases and I want to know if anything's wrong with it.
It makes the Wh_FreeStringSetting calls unnecessary, and prevents memory leaks in other cases, such as returning FALSE on line 78 or 92 after settings were loaded.

@aubymori
Copy link
Contributor Author

aubymori commented Nov 5, 2023

Why not WindhawkUtils::StringSetting? It was created just for these cases and I want to know if anything's wrong with it. It makes the Wh_FreeStringSetting calls unnecessary, and prevents memory leaks in other cases, such as returning FALSE on line 78 or 92 after settings were loaded.

Ah, sorry, I was having a bit of confusion with it, I was attempting to call the constructor directly.

@m417z m417z merged commit 1215584 into ramensoftware:main Nov 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants