Fixed issue of video drivers not starting properly in some computers when Windhawk with Classic theme mod is started very early during system start. #1059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e enable mod classic-theme-enable-with-extended-compatibility.wh.cpp
…th 1ms polling in case the conditions require to retry applying the classic theme.
…ince classic theme supports only that.
… Windhawk service, which is necessary to ensure that classic theme is properly applied before any programs including Taskbar run. The mod code is same, only readme instruction has changed. Also added one more classic theme related mod to the recommended mods list in the readme.
…when Windhawk with Classic theme mod is started very early during system start.
m417z
reviewed
Oct 11, 2024
| #else | ||
| DWORD waitInterval = 1; | ||
| #endif | ||
| if (WaitForSingleObject(g_initThreadStopSignal, waitInterval) != WAIT_TIMEOUT) { |
There was a problem hiding this comment.
Is this the actual change? I assume it will still be 1?
There was a problem hiding this comment.
No, actual change is on line 398. Before it applied the session connected status check only to RDP sessions. Now it applies it to console sessions as well.
The code snippet you cited is
#ifdef _DEBUG
DWORD waitInterval = 1000;
#else
DWORD waitInterval = 1;
#endif
So the interval is still 1 in a live mod.
There was a problem hiding this comment.
Totally missed it, saw only the comment :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.