Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding MAE loss and more customizability to discriminator #8

Merged
merged 4 commits into from
Oct 13, 2023

Conversation

ramanakumars
Copy link
Owner

@ramanakumars ramanakumars commented Oct 12, 2023

  • Adding MAE loss for img2img translation
  • Moving filters into generator and discriminator in the configuration so that we can also pass the boolean norm into the discriminator
  • Moved InstanceNorm before activation since this was causing issues
  • Move additional customizability into the generator and discriminator configs (e.g., activation, use_dropout, final_activation, n_layers)
  • Test norm change on other datasets

@ramanakumars ramanakumars marked this pull request as ready for review October 13, 2023 00:53
Copy link
Collaborator

@AgentM-GEG AgentM-GEG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future: Have we historically used Tanh()? would it benefit to have an activation_layer = nn.Tanh() as input args?

Copy link
Collaborator

@AgentM-GEG AgentM-GEG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; In the ethos of our other repos, for future it may be beneficial to have Adam vs. NAdam vs. Adagrad etc as input configurable variables. Of note again are the hyper params for Adam/NAdam .. sometimes betas = (0.9, 0.99) work better and sometimes betas (0.9, 0.999).

@AgentM-GEG AgentM-GEG merged commit 5d7866b into main Oct 13, 2023
4 checks passed
@ramanakumars ramanakumars deleted the mae_loss branch November 21, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants