Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exiftool, Check whether exiftool is installed in the host system #7

Closed
wants to merge 1 commit into from
Closed

exiftool, Check whether exiftool is installed in the host system #7

wants to merge 1 commit into from

Conversation

dgrammlich
Copy link

@ramack
Copy link
Owner

ramack commented Oct 11, 2019

Thanks a lot for your contribution! You PR will finally hide the fact that exiftool binary was not found on the server, in which case the use of the plugin is a bit strange from the start. By hiding the error I fear, that it might even trigger more questions, because it will not be visible - not even the administrator - to see that it will never do anything useful.

So I think merging this makes sense as soon as we have a a message in the admin panel.

@ramack
Copy link
Owner

ramack commented Oct 11, 2019

ah BTW, did you take a look at #5? which solution do you prefer? But anyhow this also doesn't solve the problem that the server admin might install the plugin without it doing something useful ever without any warning...

@dgrammlich dgrammlich closed this by deleting the head repository Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants