-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Json.value(object) Method and JsonSerializable Interface #81
base: master
Are you sure you want to change the base?
Conversation
@pbi-qfs why would char[] objects become JSON strings? Seems counter-intuitive, even though the conversion always works. This is creating a single exception to the "an array goes in, an array comes out" pattern. |
@mafagafogigante you're right, maybe I wrote to much eclipse compiler stuff, so in my head, char[] and Strings became equal... I gladly changed this, so the API is more consistent. |
I understand, but the library should not cause surprises. And while a string is a string, a char[] is an array. I don't think I will use this stuff anytime soon, but I understand that there might be use cases for it. Additionally, it has improved a lot from your initial proposal. As long as it doesn't degrade parsing performance (which it doesn't), I am OK with it. Good luck. |
@mafagafogigante Thanks for your review and your positive vote. @ralfstx Anything missing for a merge? |
To create JsonValues directly from complex java objects. Extends PR #80