Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Json.value(object) Method and JsonSerializable Interface #81

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

pbi-qfs
Copy link

@pbi-qfs pbi-qfs commented Jun 1, 2017

To create JsonValues directly from complex java objects. Extends PR #80

@bernardosulzbach
Copy link
Contributor

@pbi-qfs why would char[] objects become JSON strings? Seems counter-intuitive, even though the conversion always works. This is creating a single exception to the "an array goes in, an array comes out" pattern.

@pbi-qfs
Copy link
Author

pbi-qfs commented Jun 1, 2017

@mafagafogigante you're right, maybe I wrote to much eclipse compiler stuff, so in my head, char[] and Strings became equal...

I gladly changed this, so the API is more consistent.

@bernardosulzbach
Copy link
Contributor

I understand, but the library should not cause surprises. And while a string is a string, a char[] is an array.

I don't think I will use this stuff anytime soon, but I understand that there might be use cases for it.

Additionally, it has improved a lot from your initial proposal. As long as it doesn't degrade parsing performance (which it doesn't), I am OK with it. Good luck.

@pbi-qfs
Copy link
Author

pbi-qfs commented Jun 2, 2017

@mafagafogigante Thanks for your review and your positive vote.

@ralfstx Anything missing for a merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants